RFR JDK-8068448 - improve the assert

Stefan Karlsson stefan.karlsson at oracle.com
Wed Apr 8 07:43:33 UTC 2015


On 2015-04-07 22:48, Bengt Rutisson wrote:
>
> Hi Eric,
>
> On 07/04/15 20:19, Eric Caspole wrote:
>> Hi everybody,
>> Here is a patch to try to help debug this problem, by explicitly 
>> collecting more information including start array and heap size when 
>> the assert occurs.
>>
>>  http://cr.openjdk.java.net/~ecaspole/JDK-8068448/00/webrev/
>
> The change looks good to me.

Looks good to me to.

Style-wise I would prefer an extra blank line before the code section 
you added (between line 154 and 155).

Thanks,
StefanK

>
> However, I think you should use a separate bug number to track this 
> change. JDK-8068448 should probably be used when you push the actual 
> fix for the issue.
>
> Thanks,
> Bengt
>
>>
>> Passes JPRT.
>> Thanks,
>> Eric
>>
>



More information about the hotspot-gc-dev mailing list