RFR: 8076265: Simplify deal_with_reference

Kim Barrett kim.barrett at oracle.com
Wed Apr 8 14:28:24 UTC 2015


On Apr 8, 2015, at 5:29 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> 
> Hi,
> 
> On Wed, 2015-04-08 at 11:17 +0200, Bengt Rutisson wrote:
>> Hi Kim,
>> 
>> Latest webrev looks good to me. Thanks for doing this cleanup!
>> 
>> One minor nit. The comment for CMTask::is_below_finger() is not very 
>> useful in my view:
>> 
>> 1103   // Helper for deal_with_reference().
>> 1104   bool is_below_finger(HeapWord* objAddr, HeapWord* global_finger) 
>> const;
>> 
>> I'd prefer to leave that out. I don't need to see a new webrev for that. 
>> And if you feel strongly that the comment should be there I'm fine with 
>> leaving it too.
> 
>  I would put the first sentence in the comment within the body of
> is_below_finger() here instead of this sentence. I do not need a
> re-review if you make that change either.
> 
> Looks good.
> 
> Thanks,
>  Thomas

Thomas and Bengt,

Thanks for your reviews.

Regarding the comment for is_below_finger, I'm moving it to the
description in the body of the function, in the .cpp file.



More information about the hotspot-gc-dev mailing list