Request for Review (xs) - 8077301: Optimized build is broken
kim.barrett at oracle.com
Thu Apr 9 05:26:31 UTC 2015
On Apr 8, 2015, at 10:42 PM, Jon Masamitsu <jon.masamitsu at oracle.com> wrote:
> The "optimized" target does not build. A method is used in an assert
> but is defined under #ifndef PRODUCT and should be defined under
> #ifdef ASSERT.
> I built optimized, fastdebug, and product successfully after
> the fix.
This change seems inconsistent with the function declaration in the header, which is
static void assert_all_threads_claimed() PRODUCT_RETURN;
Maybe the declaration should be changed to NOT_DEBUG_RETURN too?
I’m also confused about how “optimized” would build with the proposed change. I thought
“optimized” means neither PRODUCT nor ASSERT are defined. I see how that would fail
without the change, due to an unused variable warning, because the variable is only used
in an assert. But with this change I would expect to see a link-time error because the
function is referenced but lacks a definition.
More information about the hotspot-gc-dev