RFR(M): 6407976: GC worker number should be unsigned

Evgeniya Stepanova evgeniya.stepanova at oracle.com
Thu Apr 9 14:03:34 UTC 2015


Hi Jesper,

Thank you very much for the review and your help!

Thanks,
Jane
On 09.04.2015 16:30, Jesper Wilhelmsson wrote:
> Looks good!
> Thanks for fixing this!
>
> My only question mark is around the type cast for the atomics in 
> taskqueue.cpp. I don't see any other solution though as long as we 
> don't have atomics for uint.
> If a Reviewer is OK with this, I say ship it!
>
> Thanks,
> /Jesper
>
>
> Evgeniya Stepanova skrev den 9/4/15 14:30:
>> Hi,
>>
>> Please review fix for  JDK-6407976.
>> In some source files GC worker threads numbers are being stored as
>> signed values and same values in other classes are being stored as 
>> unsigned
>> values. Fix changed GC worker thread number to be uint.
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-6407976
>> webrev: http://cr.openjdk.java.net/~eistepan/6407976/webrev.00/
>>
>> tested by running all hotspot tests on all platforms
>>
>>
>> Thanks,
>> Jane
>>
>> //

-- 
/Evgeniya Stepanova/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20150409/db2990ea/attachment.html>


More information about the hotspot-gc-dev mailing list