RFR: JDK-8077265 Modify assert to help debug JDK-8068448

Eric Caspole eric.caspole at oracle.com
Thu Apr 9 20:54:27 UTC 2015


I think it will be more refactoring than really seems worth it to me. 
The issue I encountered is that too many of these files have the code in 
the .hpp not using an .inline.hpp so there were problems with forward 
references and I didn't want to make a ton of changes just for asserts.
Eric


On 4/9/2015 4:47 PM, Jesper Wilhelmsson wrote:
> Hi Eric,
>
> Is there any way to use the same macro in psOldGen.hpp and 
> psPromotionLAB.cpp? Maybe not, they don't have any suitable includes 
> in common as far as I can see.
> It's worth thinking about, but if it's not doable I'm fine with this 
> change.
>
> Thanks,
> /Jesper
>
>
> Eric Caspole skrev den 9/4/15 22:17:
>> Hi everybody,
>> I updated this so the psOldGen part use a macro as Stefan suggested.
>> The assert in psPromotionLAB.hpp is allocating out of an already 
>> allocated PLAB,
>> so I don't think that one will ever be hit but I want it there just 
>> in case.
>> And as Jesper suggested I made the message more helpful in the 
>> original place.
>>
>>   http://cr.openjdk.java.net/~ecaspole/JDK-8077265/01/webrev/
>>
>> Passes JPRT.
>> Thanks,
>> Eric
>>
>> On 4/9/2015 10:01 AM, Stefan Karlsson wrote:
>>> Hi Eric,
>>>
>>> On 2015-04-09 15:19, Eric Caspole wrote:
>>>> HI everybody,
>>>> Here is a webrev to add more asserts related to debugging 
>>>> JDK-8068448. Beyond
>>>> capturing more info in the original assert, after looking at 
>>>> another core I
>>>> added more asserts to make sure there is no other place where old gen
>>>> allocations would overrun the start array.
>>>
>>> Why didn't these two new asserts get the same, more informative, 
>>> error message
>>> as the first assert you changed? Maybe you could extract the check 
>>> out to a
>>> helper macro that prints the relevant information?
>>>
>>> Another point that Bengt mentioned yesterday, is that we don't 
>>> really need to
>>> print the old_gen part of the assert. It's already printed in the 
>>> hs_err file.
>>>
>>> Thanks,
>>> StefanK
>>>
>>>>
>>>>  http://cr.openjdk.java.net/~ecaspole/JDK-8077265/00/webrev/
>>>>
>>>> Passes JPRT.
>>>> Thanks,
>>>> Eric
>>>
>>



More information about the hotspot-gc-dev mailing list