RFR (S): 8077411: Remove CollectedHeap::supports_heap_inspection()

Bengt Rutisson bengt.rutisson at oracle.com
Fri Apr 10 13:35:39 UTC 2015


Thanks, Stefan!

Bengt

On 2015-04-10 15:36, Stefan Karlsson wrote:
> On 2015-04-10 15:26, Bengt Rutisson wrote:
>>
>> Hi everyone,
>>
>> Could I have a couple of reviews for this small change?
>>
>> https://bugs.openjdk.java.net/browse/JDK-8077411
>> http://cr.openjdk.java.net/~brutisso/8077411/webrev.00/
>
> Looks good to me.
>
> StefanK
>
>>
>> All implementation of CollectedHeap::supports_heap_inspection() are 
>> the same and all they do is return true. The only usage is to check 
>> whether we can initiate a VM_GC_HeapInspection operation. So, by 
>> removing the check in VM_GC_HeapInspection (since it anyway always 
>> return true) we don't need CollectedHeap::supports_heap_inspection() 
>> anymore.
>>
>> Thanks,
>> Bengt
>



More information about the hotspot-gc-dev mailing list