RFR (XXS): 8075288: malloc without free in VM_PopulateDumpSharedSpace::doit()

Kim Barrett kim.barrett at oracle.com
Mon Apr 13 05:59:10 UTC 2015


On Apr 10, 2015, at 12:52 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
> 
> On Apr 10, 2015, at 9:31 AM, Jungwoo Ha <jwha at google.com> wrote:
>> 
>> What's the conclusion? Should I fix it or discuss it separately?
> 
> I think the proposed fix, as is, is good.
> 
> I think the question of whether this code should be using malloc/free or something else (stack allocation, resource allocation) is a separate question.  I don’t know anything about the code or the context(s) in which it is used, so I don’t have an informed opinion on that.  I’m not sure this is really gc code; might be better to bring that up on the hs-dev list.

I’ve filed
https://bugs.openjdk.java.net/browse/JDK-8077567

as a runtime bug.  Looking at the history of the file in question, it appears to be “owned” by the runtime team, and is not gc at all.

You might get more response, and the needed second (and capital-R) review, by discussing on hs-rt or hs-dev list.



More information about the hotspot-gc-dev mailing list