RFR(M): 6407976: GC worker number should be unsigned

Igor Ignatyev igor.ignatyev at oracle.com
Tue Apr 14 11:54:23 UTC 2015


Hi Evgeniya,

I don't like that we have both uint and 'unsigned int'. I'd prefer to 
normalize it. otherwise the patch looks good to me.

Igor

On 04/14/2015 01:29 PM, Evgeniya Stepanova wrote:
> Hi,
>
> I still need a review for this, please take a look!
>
> Thank you!
> Jane
> On 09.04.2015 17:03, Evgeniya Stepanova wrote:
>> Hi Jesper,
>>
>> Thank you very much for the review and your help!
>>
>> Thanks,
>> Jane
>> On 09.04.2015 16:30, Jesper Wilhelmsson wrote:
>>> Looks good!
>>> Thanks for fixing this!
>>>
>>> My only question mark is around the type cast for the atomics in
>>> taskqueue.cpp. I don't see any other solution though as long as we
>>> don't have atomics for uint.
>>> If a Reviewer is OK with this, I say ship it!
>>>
>>> Thanks,
>>> /Jesper
>>>
>>>
>>> Evgeniya Stepanova skrev den 9/4/15 14:30:
>>>> Hi,
>>>>
>>>> Please review fix for  JDK-6407976.
>>>> In some source files GC worker threads numbers are being stored as
>>>> signed values and same values in other classes are being stored as
>>>> unsigned
>>>> values. Fix changed GC worker thread number to be uint.
>>>>
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-6407976
>>>> webrev: http://cr.openjdk.java.net/~eistepan/6407976/webrev.00/
>>>>
>>>> tested by running all hotspot tests on all platforms
>>>>
>>>>
>>>> Thanks,
>>>> Jane
>>>>
>>>> //
>>
>> --
>> /Evgeniya Stepanova/
>
> --
> /Evgeniya Stepanova/


More information about the hotspot-gc-dev mailing list