RFR (S): 8074546: Rename and clean up the ParGCAllocBuffer class

Joseph Provino joseph.provino at oracle.com
Tue Apr 14 14:34:14 UTC 2015


On 4/13/2015 3:25 PM, Thomas Schatzl wrote:
> Hi,
>
> On Tue, 2015-04-07 at 13:10 -0400, Joseph Provino wrote:
>> On 4/7/2015 12:41 PM, Kim Barrett wrote:
>>> On Apr 7, 2015, at 12:16 PM, Joseph Provino <joseph.provino at oracle.com> wrote:
>>>> I made the changes recommended by Kim.
>>>>
>>>> It passes jprt.
>>>>
>>>> As Kim mentioned, removing plab.h from g1CollectedHeap.hpp could potentially show
>>>> places where plab.h should be included but isn't.
>>>>
>>>> Is there something else I should do to verify there isn't a problem?
>>> The problem I was suggesting might show up is that some file uses stuff in plab.hpp but only
>>> includes g1CollectedHeap.hpp.  Removing the plab.hpp include from g1CollectedHeap.hpp
>>> might result in build failures due to missing includes of plab.hpp.
>> Agreed.
>>
>>> If it builds (on all platforms), then it should be fine.
>> It passes JPRT so I think it's okay.
> Did you try compiling without precompiled headers, ie. first configure
> with --disable-precompiled-headers and then compile locally?
Yes, it built.

joe
>
> Otherwise it looks good.
>
> Thanks,
>    Thomas
>
>



More information about the hotspot-gc-dev mailing list