RFR: 8069367: assert(_nextMarkBitMap->isMarked((HeapWord*) obj)) failed

Bengt Rutisson bengt.rutisson at oracle.com
Wed Apr 15 08:38:30 UTC 2015


On 2015-04-15 08:57, Kim Barrett wrote:
> Another round.
>
> Replaced add/remove_candidate with setter for candidate set.  Replaced
> add/remove_humongous_reclaim_candidate modifiers with setter for
> G1CollectedHeap.  These changes allow some code simplifications in the
> candidate selection.
>
> Share common arguments for initializing _in_cset_fast_test and
> _humongous_reclaim_candidates, rather than recomputing for each.
>
> Improved various comments based on review feedback.
>   
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8069367
>
> Webrev:
> http://cr.openjdk.java.net/~kbarrett/8069367/webrev.05/
>
> Incremental webrev:
> http://cr.openjdk.java.net/~kbarrett/8069367/webrev.05.incr/

Looks good to me.

In particular the updated comments look fine. Thanks for fixing this!

Bengt

>
> Testing:
> Hand testing
> JPRT
> local RefWorkload using G1
>



More information about the hotspot-gc-dev mailing list