RFR: 8071462: Remove G1ParGCAllocator::alloc_buffer_waste

Thomas Schatzl thomas.schatzl at oracle.com
Mon Apr 20 11:06:49 UTC 2015


Hi Michail,

On Fri, 2015-04-17 at 20:46 +0300, Michail Chernov wrote:
> Sorry, typos have been fixed in the message:
> 
> Webrev: http://cr.openjdk.java.net/~dpochepk/~mchernov/8071462/webrev.03/
> 
> Methods were renamed, removed extra comma, class G1PLABWasteStat was 
> removed, now G1PLAB::waste(size_t& wasted, size_t& undo_wasted) gets 2 
> references. Also I merged my changes with new changes in repo because 
> ParGCAllocBuffer and G1ParGCAllocBuffer were renamed to PLAB and G1PLAB 
> and patch does not apply clear during merging.

  looks good, except that the latest change does not compile without
precompiled headers. The problem is the use of
CollectedHeap::fill_with_object() in plab.hpp.

Please move the methods add_undo_waste(), undo_last_allocation() and
undo_allocation() into the cpp file (only add_undo_waste() is required
to, but that code is not performance critical at all and it is better to
not have so much stuff in the hpp file) and add the required include
gc_interface/collectedHeap.hpp.

(Yes, the include is already missing and probably transitively included
through something else, but it is always good to have the includes
complete).

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list