RFR: 8066444: Add CMS+ParNew support for promotion event
staffan.friberg at oracle.com
Mon Apr 20 15:25:53 UTC 2015
Not a Reviewer, but change looks good.
255 if (obj != NULL &&
You could skip the NULL check as the allocated buffer should be
large enough, but might be good to keep for clarity.
On 04/20/2015 05:51 AM, Marcus Larsson wrote:
> Please review the following patch to add PLAB tracing support for
> CMS+ParNew GC. The patch is a slightly modified version of the
> CMS+ParNew parts of Staffan Friberg's patch for JDK-8055845 . With
> the modifications, the GCTracer no longer needs to be passed around as
> an argument, and can be fetched when the events are reported.
> I tried refactoring the change to avoid the need for the other two
> added arguments as well, but since this code is part of a hot path I
> found no way of doing this without introducing a performance regression.
> local jtreg
More information about the hotspot-gc-dev