RFR (XS): 8076541: Parallel GC registers Java heap twice to NMT

Thomas Schatzl thomas.schatzl at oracle.com
Wed Apr 22 07:37:56 UTC 2015


Hi Per,

On Tue, 2015-04-21 at 17:13 +0200, Per Liden wrote:
> Hi Thomas,
> 
> On 2015-04-21 16:52, Thomas Schatzl wrote:
> > Hi all,
> >
> >    can I have reviews for the following tiny change that fixes redundant
> > method calls in parallel scavenge?
> >
> > ParallelScavengeHeap::initialize() calls
> > MemTracker::record_virtual_memory_type() although
> > Universe::reserve_heap() via the ReservedHeapSpace constructor already
> > does that.
> >
> > Also, later it checks whether the the heap has been reserved or not, and
> > exits the VM if necessary. Universe::reserve_heap() already does that.
> >[...]
> Change looks good!

Thanks for the review,
  Thomas



More information about the hotspot-gc-dev mailing list