RFR: JDK-8078405 [TESTBUG] Heap decommit failed in TestShrinkAuxiliaryData tests

Kim Barrett kim.barrett at oracle.com
Wed Apr 29 20:12:14 UTC 2015


On Apr 29, 2015, at 3:18 PM, Eric Caspole <eric.caspole at oracle.com> wrote:
> 
> Hi Thomas,
> I added the bug id in the 6 tests that use it:
> 
> http://cr.openjdk.java.net/~ecaspole/JDK-8078405/01/webrev/
> 
> This is what you meant, right?
> Thanks,
> Eric
> 
> 
> On 4/29/2015 2:50 PM, Thomas Schatzl wrote:
>> Hi Eric,
>> 
>> On Tue, 2015-04-28 at 11:37 -0400, Eric Caspole wrote:
>>> Hi everybody, could I have reviews for this fix to a test case, to set
>>> up the arguments so that the required arguments in the source file are
>>> added to the cmd line after the ones from the outside environment. In
>>> this case the test would fail because this test does not work correctly
>>> when -XX:+ExplicitGCInvokesConcurrent is used.
>>> 
>>>   http://cr.openjdk.java.net/~ecaspole/JDK-8078405/00/webrev/
>>> 
>> One thing: please add this bug id to the @bug line in the tests that use
>> that class. Otherwise it will be some searching how to verify the fix.
>> 
>> Looks good otherwise.
>> 
>> Thomas

Looks good to me too.



More information about the hotspot-gc-dev mailing list