RFR (S): 8075288: Remove dictionary NULL check on common path of BlockFreeList methods

Jungwoo Ha jwha at google.com
Thu Apr 30 06:09:49 UTC 2015


>
>
>> That style is my doing and my preference.    There remains differing
> opinions in the
> group on the style and some consider the accessors wasted effort but I
> find them
> useful often enough to prefer them.
>
> Jon
>
>>
>>
I saw this after reading runtime thread. Things are getting confused.
We can do

BlockFreelist *dictionary() { return &_dictionary; }

and keep dictionary()->XXX
This is actually consistent with _humongous_blocklist.

http://cr.openjdk.java.net/~jwha/8079091/webrev.01
current one has
BlockFreelist &dictionary() { return _dictionary; }

and changed it to dictionary().XXX

Whichever you guys prefer...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20150429/6aaf3bc9/attachment.html>


More information about the hotspot-gc-dev mailing list