RFR (XS): 8078673: Update TEST.groups for recent GC tests

David Holmes david.holmes at oracle.com
Thu Apr 30 06:33:35 UTC 2015


Hi Derek,

On 29/04/2015 7:31 AM, Derek White wrote:
> Please review this simple for GC tests that require certain collectors
> (e.g. shouldn't run in embedded).
>
> Certain GC regression tests require specific collectors to be enabled in
> the JVM (by using -XX:+UseParallelGC, etc). But these tests were not
> listed in TEST.groups.
>
> This webrev adds the following tests to the appropriate needs_g1gc,
> needs_serialgc, needs_parallelgc, and needs_cmsgc lists.
>
>   * gc/TestSmallHeap.java

I don't think it works correctly to have a test that requires multiple 
GCs be listed in the needs_XXgc for each XX used. If I want to run tests 
on a platform that only supports one GC then this will fail. I think 
such tests should really only be in the needs_gc group. Further I think 
the test will get excluded from all the applicable_YYgc group if also in 
a needs_XXgc group.

David

>   * gc/TestCardTablePageCommits.java
>   * gc/arguments/TestParallelHeapSizeFlags.java
>     gc/ergonomics/TestDynamicNumberOfGCThreads.java
>   * gc/logging/TestGCId.java
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8078673
>
> Webrev:
> http://cr.openjdk.java.net/~drwhite/8078673/webrev.00/
>
> Testing:
> JPRT
>
> Thanks,
>   - Derek


More information about the hotspot-gc-dev mailing list