RFR (M): 8073052: Rename and clean up the allocation manager hierarchy in g1Allocator.?pp

Kim Barrett kim.barrett at oracle.com
Mon Aug 3 22:43:27 UTC 2015

On Jul 29, 2015, at 3:51 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> On Tue, 2015-07-28 at 14:42 +0200, Mikael Gerdin wrote:
>> G1PLABAllocator seems to look up the G1H::heap() fairly often,
>> did you consider passing on the G1H* to the G1PLABAllocator to reduce 
>> the clutter from accessing through the static getter in multiple 
>> locations? Another option could be to expose the G1H* from G1Allocator, 
>> yielding _allocator->heap()->...
>> instead of _g1h->...
> Fixed.
> New webrevs:
> http://cr.openjdk.java.net/~tschatzl/8073052/webrev.4/ (full)
> http://cr.openjdk.java.net/~tschatzl/8073052/webrev.3_to_4/ (diff)

 186   size_t gclab_word_size = _allocator->heap()->desired_plab_sz(dest);

[here and in other places]
I was expecting to see _g1h->desired_plab_sz(dest) here, in response
to Mikael's suggestion, but I see you took his "Another option"
instead.  Any reason for that, rather than giving the G1PLABAllocator
direct access to the heap object?


Other than that one question, looks good.

More information about the hotspot-gc-dev mailing list