RFR (M): 8073052: Rename and clean up the allocation manager hierarchy in g1Allocator.?pp

Kim Barrett kim.barrett at oracle.com
Tue Aug 4 16:59:58 UTC 2015


On Aug 4, 2015, at 3:48 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> 
> PLABAllocator does not have a local reference to G1CollectedHeap. So I
> could have either added one, or used the one from the G1Allocator.
> 
> I somewhat tend to dislike the thousands of local copies of
> G1CollectedHeap for no reason.
> 
> If you strongly prefer making another copy, I can change this likewise.

Having a local reference to the heap object is pretty idiomatic in
this code base.  I'd rather follow existing practice, and dislike a
mix of mechanisms.  So yes, I'd prefer that form.



More information about the hotspot-gc-dev mailing list