RFR (M): 8073052: Rename and clean up the allocation manager hierarchy in g1Allocator.?pp

Thomas Schatzl thomas.schatzl at oracle.com
Wed Aug 5 08:13:29 UTC 2015


Hi,

On Tue, 2015-08-04 at 12:59 -0400, Kim Barrett wrote:
> On Aug 4, 2015, at 3:48 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> > 
> > PLABAllocator does not have a local reference to G1CollectedHeap. So I
> > could have either added one, or used the one from the G1Allocator.
> > 
> > I somewhat tend to dislike the thousands of local copies of
> > G1CollectedHeap for no reason.
> > 
> > If you strongly prefer making another copy, I can change this likewise.
> 
> Having a local reference to the heap object is pretty idiomatic in
> this code base.  I'd rather follow existing practice, and dislike a
> mix of mechanisms.  So yes, I'd prefer that form.

  new webrev:
http://cr.openjdk.java.net/~tschatzl/8073052/webrev.5
http://cr.openjdk.java.net/~tschatzl/8073052/webrev.4_to_5

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list