RFR (XXS): 8133043: Clean up code related to termination stats printing

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Wed Aug 5 14:18:14 UTC 2015


Looks good! Thanks for cleaning this up!

Do you mind adding an empty line between the method declarations in 
g1ParScanThreadState.hpp?

  146   // Print the header for the per-thread termination statistics.
  147   static void print_termination_stats_hdr(outputStream* const st = 
gclog_or_tty);
-------- New empty line :)
  148   // Print actual per-thread termination statistics.
  149   void print_termination_stats(outputStream* const st = gclog_or_tty) const;

Thanks,
/Jesper


Thomas Schatzl skrev den 5/8/15 13:59:
> Hi all,
>
>    can I have some reviews for the following change that cleans up and
> reformats the code and usage related to G1 termination stats?
>
> Stuff like not using braces around if-clauses, dropping an extra
> temporary lock, linebreaks in string constants, line breaks in the
> definition of the methods, superfluous additional parameters.
>
> I generally do not do reformatting changes, but every time I browse
> through that code it gives me an urge to fix that.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8133043
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8133043/webrev/
> Testing:
> compilation, gcbasher run with -XX:+PrintTerminationStats, jprt
>
> Thanks,
>    Thomas
>


More information about the hotspot-gc-dev mailing list