RFR (XXS): 8133043: Clean up code related to termination stats printing

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Wed Aug 5 14:31:57 UTC 2015


Ship it!
/Jesper

Thomas Schatzl skrev den 5/8/15 16:25:
> Hi Jesper,
>
>
> On Wed, 2015-08-05 at 16:18 +0200, Jesper Wilhelmsson wrote:
>> Looks good! Thanks for cleaning this up!
>
>    thanks for the review.
>
>>
>> Do you mind adding an empty line between the method declarations in
>> g1ParScanThreadState.hpp?
>>
>>    146   // Print the header for the per-thread termination statistics.
>>    147   static void print_termination_stats_hdr(outputStream* const st =
>> gclog_or_tty);
>> -------- New empty line :)
>>    148   // Print actual per-thread termination statistics.
>>    149   void print_termination_stats(outputStream* const st = gclog_or_tty) const;
>>
>
> New webrevs at
> http://cr.openjdk.java.net/~tschatzl/8133043/webrev.1 (full)
> http://cr.openjdk.java.net/~tschatzl/8133043/webrev.0_to_1/ (diff)
>
> Thanks,
>    Thomas
>
>


More information about the hotspot-gc-dev mailing list