RFR (XXS): 8133043: Clean up code related to termination stats printing
jon.masamitsu at oracle.com
Wed Aug 5 15:52:02 UTC 2015
You substituted _queue_num for i (worker_id) in
- i, elapsed_ms, s_roots_ms, s_roots_ms * 100 / elapsed_ms,
+ _queue_num, elapsed_ms, s_roots_ms, s_roots_ms * 100 / elapsed_ms,
I can see how _queue_num would be more interesting but is worker_id just
of no value so it is not worth printing? I don't have any perspective
so I'm not objecting to dropping the worker_id. Just wondering if
less is better. And you can push it as is.
Rest looks good.
On 8/5/2015 4:59 AM, Thomas Schatzl wrote:
> Hi all,
> can I have some reviews for the following change that cleans up and
> reformats the code and usage related to G1 termination stats?
> Stuff like not using braces around if-clauses, dropping an extra
> temporary lock, linebreaks in string constants, line breaks in the
> definition of the methods, superfluous additional parameters.
> I generally do not do reformatting changes, but every time I browse
> through that code it gives me an urge to fix that.
> compilation, gcbasher run with -XX:+PrintTerminationStats, jprt
More information about the hotspot-gc-dev