RFR (XS): Move implementation of process_grey_object to concurrentMark.inline.hpp

Siebenborn, Axel axel.siebenborn at sap.com
Thu Aug 6 13:49:50 UTC 2015


Hi,
Could I have reviews and a sponsor for this small change 

We had a linker problem with a C++ - compiler that inlined process_grey_object at all uses but removed the symbol and the actual implementation.
As there are explicit instantiations of this method in concurrentMark.cpp, this probably should not happen and can be considered of a bug of the C++ compiler. Though, it seems to be pointless to mark that method inline if there are explicit instantiations.

Considering performance, it would be better to move the implementation of process_grey_object to concurrentMark.inline.hpp in order to inline the method in other compilation units.

CR:
https://bugs.openjdk.java.net/browse/JDK-8133121

Webrev:
http://cr.openjdk.java.net/~asiebenborn/8133121/webrev/


Thanks,
Axel


More information about the hotspot-gc-dev mailing list