RFR (XXS): 8133042: Remove some direct accesses of G1Allocator::reuse_retained_old_region() to G1CollectedHeap members

Thomas Schatzl thomas.schatzl at oracle.com
Thu Aug 6 15:58:00 UTC 2015


Hi Kim,

  thanks for the review.

On Thu, 2015-08-06 at 11:24 -0400, Kim Barrett wrote:
> On Aug 6, 2015, at 10:50 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> > 
> >> There is very similar code to what is being changed here in G1ArchiveAllocator::alloc_new_region,
> >> later in the same file (g1Allocator.cpp).
> >> 
> >> Would the proposed change or the additional change to alloc_new_region permit the elimination
> >> of any friend declarations from G1CollectedHeap? 
> > 
> >  only if some additional methods from G1CollectedHeap were made public.
> > 
> > Here is a webrev doing that:
> > http://cr.openjdk.java.net/~tschatzl/8133042/webrev.1/ (full only
> > because the original change has been so tiny)
> > 
> > I am fine with either version.
> 
> Looks good.
> 
> One tiny nit:

> src/share/vm/gc/g1/g1CollectedHeap.hpp
>  700   // It dirties the cards that cover the block so that so that the post
> 
> [pre-existing]
> "so that so that" => "so that"

  I allowed myselves to just update the webrevs in place for this tiny
change.

http://cr.openjdk.java.net/~tschatzl/8133042/webrev.1/

Thanks,
  Thomas





More information about the hotspot-gc-dev mailing list