RFR (S): 8131734: Add free_archive_regions support to G1 for -Xshared:auto

Dmitry Dmitriev dmitry.dmitriev at oracle.com
Thu Aug 6 21:59:23 UTC 2015


Hello Jiangli,

I have few comments/questions.

src/share/vm/memory/filemap.cpp module:
1) Should free_archive_regions also called when verify_string_regions() 
returns false on line 717?
2) The same question about unmap_string_regions(). Region must be freed 
when unmap_string_regions() is called?
3) Extra space at the end of the line 711.

  test/runtime/SharedArchiveFile/SharedStringsRunAuto.java
1) Unneeded second creating of OutputAnalyzer on line 61. Also, probably 
will be better to use same scheme for OutputAnalyzer? On lines 46-49 you 
not use local variable, but on lines 61-63 use local variable.
   59         OutputAnalyzer output = new OutputAnalyzer(pb.start());
   60
   61         output = new OutputAnalyzer(pb.start());
2) Extra space at the end of the lines 25,26,30, 51

Thanks,
Dmitry

On 07.08.2015 0:32, Jiangli Zhou wrote:
> Hi,
>
> Here is the runtime part of the bug fix that calls the new 
> free_archive_regions() when shared string mapping fails. I also added 
> a jtreg test to test shared strings with -Xshare:auto.
>
> http://cr.openjdk.java.net/~jiangli/8131734/webrev.00/ 
> <http://cr.openjdk.java.net/%7Ejiangli/8131734/webrev.00/>
>
> Test:
> - Tested by explicitly making the shared string mapping fail on 
> linux-x64, -Xshare:auto runs without crash with the fix
> - Tested with the new SharedStringsRunAuto test
> - Tested with XX:+PrintNMTStatistics -XX:NativeMemoryTracking=detail
>
> Thanks,
> Jiangli

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20150807/fc052a2e/attachment.html>


More information about the hotspot-gc-dev mailing list