RFR (XS): Move implementation of process_grey_object to concurrentMark.inline.hpp

Volker Simonis volker.simonis at gmail.com
Thu Aug 13 14:42:55 UTC 2015


On Thu, Aug 13, 2015 at 3:52 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
> On Aug 13, 2015, at 5:55 AM, Siebenborn, Axel <axel.siebenborn at sap.com> wrote:
>>
>> On 12.08.2015, at 21:57, Kim Barrett wrote:
>>>  (If Axel has time, I'm mildly curious whether just
>>> removing the inline qualifier also works around the problem.)
>> We were curious too and  indeed, removing the inline qualifier would work around the problem.
>
> Interesting.  I may spend some time this afternoon re-reading bits of the standard,
> but I think you should report this as a bug to your compiler vendor.
>
>>> I have one optional change to suggest, which is to move the inline
>>> definition of scan_object from the .hpp file to the .inline.hpp file.
>>> I think putting it in the .hpp file was a mistake on my part.  Axel,
>>> let me know whether you want to make that additional change.
>> Yes, there is the new webrev:
>>
>> http://cr.openjdk.java.net/~asiebenborn/8133121_0/webrev/
>
> Looks good.
>
>> Thanks for reviewing and sponsoring,
>> Axel
>
> No problem.  I’m guessing Volker likes this version too, but I’d like an email ACK before pushing.
>

Hi Kim,

yes, I like the new version:)
Would be great if you could push it.

Thanks,
Volker


More information about the hotspot-gc-dev mailing list