RFR (S): 8133530: Add JFR event for evacuation statistics

Staffan Friberg staffan.friberg at oracle.com
Fri Aug 14 16:41:05 UTC 2015


Hi Thomas,

Any reason to go via the G1EvacSummary class and not just send the stats 
(G1EvacStats) straight through to the event code?

It seems like it just adds a very short live object and a lot of copies 
of different fields, but I might miss some bigger picture thing.

Thanks,
Staffan


On 08/14/2015 04:30 AM, Mikael Gerdin wrote:
> Hi Thomas,
>
> On 2015-08-13 17:43, Thomas Schatzl wrote:
>> Hi all,
>>
>>    can I have reviews for this split-out from 8073013 that adds JFR
>> support for evacuation statistics.
>>
>> The code has been changed to (hopefully) correspond better to the way
>> code that sends JFR events should look like.
>>
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8133530
>> Webrev:
>> http://cr.openjdk.java.net/~tschatzl/8133530/webrev/
>
> in gcTrace.hpp
> 39 #include "gc/g1/g1YCTypes.hpp"
> 40 #include "gcHeapSummary.hpp"
> 41 #endif
> 42
>
> you should use the full path to gcHeapSummary.hpp
>
> in gcTraceSend.cpp
> 240   if (surv_evt.should_commit()) {
> 241     surv_evt.set_gcId(GCId::peek().id());
> 242     surv_evt.set_allocated(summary.allocated() * HeapWordSize);
>
> The other events use
> 232     e.set_gcId(_shared_gc_info.gc_id().id());
>
> When you assert_set_gc_id you actually verify that the shared gc info 
> id is set.
>
> /Mikael
>
>>
>> Testing:
>> jprt
>>
>> Thanks,
>>    Thomas
>>
>



More information about the hotspot-gc-dev mailing list