RFR: 8130308 - Too low memory usage in TestPromotionFromSurvivorToTenuredAfterMinorGC.java

Dmitry Fazunenko dmitry.fazunenko at oracle.com
Mon Aug 17 19:57:40 UTC 2015


Hi Jesper,

The fix looks good to me.

Thanks,
Dima

On 17.08.2015 22:37, Jesper Wilhelmsson wrote:
> Hi,
>
> Please review this fix for 
> TestPromotionFromSurvivorToTenuredAfterMinorGC.java
>
> Basically what happened was:
>
> 1. The test stores the amount of used heap
> 2. Some allocation is done and a series of GCs are called
> 3. The test keeps track of anything allocated during the test by other 
> threads
> 4. Verify that the total amount of used old gen is what we expect 
> based on how much was allocated.
>
> The problem was that if data was allocated and was still in the 
> survivor space it was included in the expected size, but not included 
> in the verification.
>
> Since the test is all about tenured space and verifying that, I 
> decided to reduce the expected amount by what's used in the survivor 
> area rather than including the survivor area in the verification.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8130308
> Webrev: http://cr.openjdk.java.net/~jwilhelm/8130308/webrev.00/
>
> Thanks,
> /Jesper



More information about the hotspot-gc-dev mailing list