RFR (S): 8133530: Add JFR event for evacuation statistics

Erik Helin erik.helin at oracle.com
Tue Aug 18 15:18:04 UTC 2015


On 2015-08-18, Thomas Schatzl wrote:
> Hi all,
> 
>   Erik had some further comments in private regarding style and better
> encapsulation of the code.
> 
> Here are the new webrevs:
> http://cr.openjdk.java.net/~tschatzl/8133530/webrev.2 (full)
> http://cr.openjdk.java.net/~tschatzl/8133530/webrev.1_to_2 (full)

Looks good, Reviewed.

Thanks,
Erik

> Main changes are about moving the G1NewTracer::create_g1_evacstats()
> methods into the cpp file as a static method.
> 
> Thanks,
>   Thomas
> 
> On Mon, 2015-08-17 at 15:30 +0200, Thomas Schatzl wrote:
> > Hi Mikael,
> > 
> > On Fri, 2015-08-14 at 13:30 +0200, Mikael Gerdin wrote:
> > > Hi Thomas,
> > > 
> > > On 2015-08-13 17:43, Thomas Schatzl wrote:
> > > > Hi all,
> > > >
> > > >    can I have reviews for this split-out from 8073013 that adds JFR
> > > > support for evacuation statistics.
> > > >
> > > > The code has been changed to (hopefully) correspond better to the way
> > > > code that sends JFR events should look like.
> > > >
> > > > CR:
> > > > https://bugs.openjdk.java.net/browse/JDK-8133530
> > > > Webrev:
> > > > http://cr.openjdk.java.net/~tschatzl/8133530/webrev/
> > > 
> > > in gcTrace.hpp
> > > 39 #include "gc/g1/g1YCTypes.hpp"
> > > 40 #include "gcHeapSummary.hpp"
> > > 41 #endif
> > > 42
> > > 
> > > you should use the full path to gcHeapSummary.hpp
> > > 
> > > in gcTraceSend.cpp
> > > 240   if (surv_evt.should_commit()) {
> > > 241     surv_evt.set_gcId(GCId::peek().id());
> > > 242     surv_evt.set_allocated(summary.allocated() * HeapWordSize);
> > > 
> > > The other events use
> > > 232     e.set_gcId(_shared_gc_info.gc_id().id());
> > > 
> > > When you assert_set_gc_id you actually verify that the shared gc info id 
> > > is set.
> > 
> >   all fixed in 
> > http://cr.openjdk.java.net/~tschatzl/8133530/webrev.0_to_1 (diff)
> > http://cr.openjdk.java.net/~tschatzl/8133530/webrev.1 (full)
> > 
> > I also incorporated a suggestion by Erik that extracted the common
> > members of the two new events into a single (JFR) struct to benefit a
> > little from refactoring.
> > 
> > Thanks,
> >   Thomas
> > 
> > 
> 
> 


More information about the hotspot-gc-dev mailing list