RFR: 8131330: G1CollectedHeap::verify_dirty_young_list fails with assert

Kim Barrett kim.barrett at oracle.com
Wed Aug 19 20:48:21 UTC 2015


On Aug 19, 2015, at 1:51 PM, Eric Caspole <eric.caspole at oracle.com> wrote:
> 
> Is it allowed to use a more descriptive label name than 1,2,3 in the sparc inline asm? I expect this works fine and no one will ever look at it again but just in case, I think it is easier to read and see the use of the labels if it is a descriptive word.
> The rest of it looks good.
> Thanks,

Thanks Eric.

gcc extended asm provides a syntax for unique named labels, using
"%=".  But I couldn't get that to work under Solaris Studio.  This
might be a limitation of Solaris Studio's implementation of gcc's
extended asm.  Or it might be just a failure on my part to figure out
the right syntax.

I added a few comments to make it easier to spot the branches and
labels.

New webrev:
http://cr.openjdk.java.net/~kbarrett/8131330/webrev.01/

Incremental webrev:
http://cr.openjdk.java.net/~kbarrett/8131330/webrev.01.inc1/



More information about the hotspot-gc-dev mailing list