Request for code review - 8130265: gctests/LargeObjects/large001 fails with OutOfMemoryError: Java heap space
kim.barrett at oracle.com
Wed Aug 19 22:43:54 UTC 2015
On Aug 19, 2015, at 5:02 PM, Alexander Harlap <alexander.harlap at oracle.com> wrote:
> I agree.
> Here is new revision:
> On 8/19/2015 4:36 PM, Jesper Wilhelmsson wrote:
>> Hi Alex,
>> Yes, I like this version much better.
>> I'm fine with the change as is, but would it make sense to add the same code after the first GC as well? So that every attempt_allocation_at_safepoint is followed by an expand_and_allocate. We could avoid a GC in some cases.
One very minor nit: Hotspot coding style guide says "As a general rule don't add bug numbers to comments.”
1778 // Expand heap will help - JDK-8130265
More information about the hotspot-gc-dev