RFR: 8131330: G1CollectedHeap::verify_dirty_young_list fails with assert

Kim Barrett kim.barrett at oracle.com
Thu Aug 20 20:29:46 UTC 2015


On Aug 20, 2015, at 11:00 AM, Kim Barrett <kim.barrett at oracle.com> wrote:
> 
> So why isn't the fill_subword helper function declared inline, you
> might ask?
> 
> Because during development it made sense to have it not inlined, and I
> forgot to reconsider that later.  Sigh!  I'll fix that and post a new
> webrev this afternoon.

Here's the new version.  I moved the fill_subword helper before its
caller and changed it to inline rather than static.

That change provoked a compiler warning that reminded me that
temporaries for inline assembler should be declared in the outputs and
then just left unreferenced after the asm statement.  I'd mistakenly
had them in the inputs.  Fixed now.

Full webrev:
http://cr.openjdk.java.net/~kbarrett/8131330/webrev.02/

Incremental webrev:
http://cr.openjdk.java.net/~kbarrett/8131330/webrev.02.inc2/



More information about the hotspot-gc-dev mailing list