RFR (XXS): 8133456: HeapRegionManager::shrink_by() iterates suboptimally across regions

Thomas Schatzl thomas.schatzl at oracle.com
Mon Aug 24 10:24:32 UTC 2015


Hi Tom,

On Fri, 2015-08-21 at 08:03 -0400, Tom Benson wrote:
> Hi,
> The change looks good to me.
> 

  thanks for the review.

> On the in/out parameter question, I'd say I slightly favor the two 
> parameters.   On a related trivial note, I'd also prefer it slightly if 
> find_available_from_idx_reverse had the index as return value, with the 
> count as the output parameter.  Same for find_unavailable_from_idx.  
> Then they would be consistent with find_contiguous and 
> find_highest_free, and there wouldn't be 2 index params to look odd.   
> But that's another change.

I created https://bugs.openjdk.java.net/browse/JDK-8134299.

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list