RFR: 8072817: CardTableExtension kind() should be BarrierSet::CardTableExtension

Kim Barrett kim.barrett at oracle.com
Thu Aug 27 20:45:57 UTC 2015


On Aug 27, 2015, at 2:48 PM, Jesper Wilhelmsson <jesper.wilhelmsson at oracle.com> wrote:
> 
> Hi Kim,
> 
> Looks good in general.
> 
> In src/cpu/aarch64/vm/macroAssembler_aarch64.cpp there is a comma between the two checks:
> 
> +  assert(bs->kind() == BarrierSet::CardTableForRS,
> +         bs->kind() == BarrierSet::CardTableExtension,
> +         "Wrong barrier set kind");
> 
> I assume there should be a ||
> 
> Besides that the patch seems to do what you described below.

You are correct.  Unfortunately, jprt doesn’t test the platform that uses that file.



More information about the hotspot-gc-dev mailing list