RFR: JDK-8068589: GCCause should distinguish jcmd GC.run from System.gc()

Kirk Pepperdine kirk at kodewerk.com
Tue Feb 3 09:57:41 UTC 2015


Hi,

Not an official review but it’s a simple patch that looks good.

Kind regards,
Kirk

On Feb 2, 2015, at 4:51 PM, Yasumasa Suenaga <yasuenag at gmail.com> wrote:

> Hi,
> 
> I need more reviewer.
> Could you review it?
> 
> http://cr.openjdk.java.net/~ysuenaga/JDK-8068589/webrev.02/
> 
> Thanks,
> 
> Yasumasa
> 
> 2015/01/28 17:24 "Staffan Larsen" <staffan.larsen at oracle.com>:
> Looks good!
> 
> Thanks,
> /Staffan
> 
> > On 28 jan 2015, at 05:48, Yasumasa Suenaga <yasuenag at gmail.com> wrote:
> >
> > Hi Staffan, Kirk,
> >
> > I agree to set "Diagnostic Command" to GCCause.
> > So I applied it to new patch.
> >
> > http://cr.openjdk.java.net/~ysuenaga/JDK-8068589/webrev.02/
> >
> > Could you review it again?
> >
> >
> > Thanks,
> >
> > Yasumasa
> >
> >
> > On 2015/01/28 5:06, Kirk Pepperdine wrote:
> >> Hi Staffan,
> >>
> >>>>
> >>>> Anyway, it’s a record in a GC log so I don’t see the value of GC.run. Certainly “DiagCmd" or even "Diagnostic Command” seems sufficient given the context.
> >>>
> >>> Let’s go with “Diagnostic Command”, then.
> >>
> >> Thank you!
> >>
> >> Regards,
> >> Kirk
> >>
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20150203/ddf133fa/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 496 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20150203/ddf133fa/signature.asc>


More information about the hotspot-gc-dev mailing list