[8u60] (XS) RFR: 8071972: Minimal VM is broken

David Holmes david.holmes at oracle.com
Wed Feb 4 09:27:23 UTC 2015


Hi Stefan,

On 4/02/2015 7:12 PM, Stefan Karlsson wrote:
> Hi David,
>
> On 2015-02-02 05:51, David Holmes wrote:
>> http://cr.openjdk.java.net/~dholmes/8071972/webrev.8u60/
>
> Looks fine.
>
> Some bikeshedding: we usually don't add newlines between the sections in
> the include list:
>
>    35 #include "utilities/macros.hpp"
>    36
>    37 #if INCLUDE_ALL_GCS
>    38 #include "gc_implementation/shared/parGCAllocBuffer.hpp"
>    39 #endif
>
> so I'd prefer if you removed lined 36.

Fixed.

Thanks for the Reviews.

David

> Thanks,
> StefanK
>
>>
>> Original bug is confidential but the backport issue is not:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8072057
>>
>> Simple fix to ensure header inclusion is guarded based on all GCs
>> being included.
>>
>> This fix is not applicable to 9 due to the changes there that have
>> removed the parNew and defNew support. In fact inclusion of this
>> header is no longer needed in 9 and I've filed
>>
>> https://bugs.openjdk.java.net/browse/JDK-8072056
>>
>> to clean that up.
>>
>> Thanks,
>> David
>


More information about the hotspot-gc-dev mailing list