Need a sponsor for push into jdk9/hs-gc

Alexander Harlap alexander.harlap at oracle.com
Wed Feb 4 18:46:11 UTC 2015


I need a sponsor to push fix for JDK-806746 
<https://bugs.openjdk.java.net/browse/JDK-8067460>

Alex
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20150204/c9f9c718/attachment.html>
-------------- next part --------------
# HG changeset patch
# User aharlap
# Date 1423074128 18000
# Node ID de01bdc06cffb5f4f39ca73284c22c296522364d
# Parent  2e0533911320a3ad32b266a4d513c097c7d75deb
8067460: G1: TestResourceManagementFlagWithCommercialBuild.java failed on embedded platform
Reviewed-by: dholmes, aharlap

diff -r 2e0533911320 -r de01bdc06cff share/vm/runtime/arguments_ext.hpp
--- a/share/vm/runtime/arguments_ext.hpp	Tue Jan 27 22:06:44 2015 +0100
+++ b/share/vm/runtime/arguments_ext.hpp	Wed Feb 04 13:22:08 2015 -0500
@@ -20,6 +20,7 @@
   // no additional parsing needed in Arguments::parse() open code
   // for the option. Otherwise returns false.
   static inline bool process_options(const JavaVMOption *option);
+  static inline void report_unsupported_options();
 
 private:
   static        void report_error(const char * msg);
@@ -51,6 +52,19 @@
   return true;
 }
 
+void ArgumentsExt::report_unsupported_options() {
+#if INCLUDE_ALL_GCS
+  #if (defined JAVASE_EMBEDDED || defined ARM)
+  // Resource Management needs G1 GC which is not available in this case
+  UNSUPPORTED_OPTION(ResourceManagement, "Resource Management");
+  #endif // (defined JAVASE_EMBEDDED || defined ARM)
+#else
+  // Resource Management needs G1 GC which is not available in this case
+  UNSUPPORTED_OPTION(ResourceManagement, "Resource Management");
+#endif // INCLUDE_ALL_GCS
+}
+
+
 bool ArgumentsExt::check_gc_consistency_ergo() {
   return Arguments::check_gc_consistency_ergo() && check_resource_management();
 }
-------------- next part --------------
# HG changeset patch
# User aharlap
# Date 1423073667 18000
# Node ID eca97ddf09401f2fdd3bb0ba4ca9ccd7947e47da
# Parent  0f8fc58bc5a2bea4bedd4ed35aaff7018a1d33a5
8067460: G1: TestResourceManagementFlagWithCommercialBuild.java failed on embedded platform
Reviewed-by: dholmes, bdelsart

diff -r 0f8fc58bc5a2 -r eca97ddf0940 src/share/vm/runtime/arguments.cpp
--- a/src/share/vm/runtime/arguments.cpp	Mon Jan 26 17:00:39 2015 -0800
+++ b/src/share/vm/runtime/arguments.cpp	Wed Feb 04 13:14:27 2015 -0500
@@ -57,18 +57,6 @@
 #define DEFAULT_VENDOR_URL_BUG "http://bugreport.java.com/bugreport/crash.jsp"
 #define DEFAULT_JAVA_LAUNCHER  "generic"
 
-// Disable options not supported in this release, with a warning if they
-// were explicitly requested on the command-line
-#define UNSUPPORTED_OPTION(opt, description)                    \
-do {                                                            \
-  if (opt) {                                                    \
-    if (FLAG_IS_CMDLINE(opt)) {                                 \
-      warning(description " is disabled in this release.");     \
-    }                                                           \
-    FLAG_SET_DEFAULT(opt, false);                               \
-  }                                                             \
-} while(0)
-
 #define UNSUPPORTED_GC_OPTION(gc)                                     \
 do {                                                                  \
   if (gc) {                                                           \
@@ -3851,6 +3839,8 @@
   #endif
 #endif
 
+  ArgumentsExt::report_unsupported_options();
+
 #ifndef PRODUCT
   if (TraceBytecodesAt != 0) {
     TraceBytecodes = true;
diff -r 0f8fc58bc5a2 -r eca97ddf0940 src/share/vm/runtime/arguments.hpp
--- a/src/share/vm/runtime/arguments.hpp	Mon Jan 26 17:00:39 2015 -0800
+++ b/src/share/vm/runtime/arguments.hpp	Wed Feb 04 13:14:27 2015 -0500
@@ -632,4 +632,16 @@
   return check_gc_consistency_user();
 }
 
+// Disable options not supported in this release, with a warning if they
+// were explicitly requested on the command-line
+#define UNSUPPORTED_OPTION(opt, description)                    \
+do {                                                            \
+  if (opt) {                                                    \
+    if (FLAG_IS_CMDLINE(opt)) {                                 \
+      warning(description " is disabled in this release.");     \
+    }                                                           \
+    FLAG_SET_DEFAULT(opt, false);                               \
+  }                                                             \
+} while(0)
+
 #endif // SHARE_VM_RUNTIME_ARGUMENTS_HPP
diff -r 0f8fc58bc5a2 -r eca97ddf0940 src/share/vm/runtime/arguments_ext.hpp
--- a/src/share/vm/runtime/arguments_ext.hpp	Mon Jan 26 17:00:39 2015 -0800
+++ b/src/share/vm/runtime/arguments_ext.hpp	Wed Feb 04 13:14:27 2015 -0500
@@ -37,6 +37,7 @@
   // no additional parsing needed in Arguments::parse() for the option.
   // Otherwise returns false.
   static inline bool process_options(const JavaVMOption *option) { return false; }
+  static inline void report_unsupported_options() { }
 };
 
 void ArgumentsExt::select_gc_ergonomically() {


More information about the hotspot-gc-dev mailing list