RFR: 8066771: Refactor VM GC operations caused by allocation failure

Jon Masamitsu jon.masamitsu at oracle.com
Wed Feb 4 21:21:15 UTC 2015


Marcus,

Many of the changes seem not to relate directly to the
CR.  For example the change "unsigned int -> uint" are
the only changes is some files.  Though that would be
bearable in a code review, it makes  more work for
sustaining when they go hunting for a change that lead
to a bug.   Please consider integrating those under
a different CR.

Please create a CR to rename the sub-classes of
VM_CollectForAllocation with synopsis "Regularize
name of VM_CollectForAllocation and subclasses".
Assign it to me.

The changes themselves look good.

Pending your decision of separating out the unrelated
changes, consider it reviewed.

Jon

On 2/4/2015 7:30 AM, Marcus Larsson wrote:
> Hello again,
>
> Still looking for reviews for this old forgotten change.
>
> Thanks,
> Marcus
>
> On 08/12/14 12:39, Marcus Larsson wrote:
>> Hi,
>>
>> I would like reviews for the following patch, cleaning up and 
>> refactoring VM GC operations for failed allocations.
>>
>> Summary:
>> Different GCs have specialized VM_GC_Operations for collecting due to 
>> allocation failure. Part of this code is duplicated. The patch adds a 
>> VM_CollectForAllocation class that removes this duplicated code and 
>> handles the allocation size and result for such operations. It also 
>> serves as a common base where tracing can easily be added for these 
>> operations, regardless of which GC is used.
>>
>> In addition to the above refactoring, the patch also cleans up around 
>> the VM GC operations. These changes include:
>>   * Indentation and whitespace fixes
>>   * Change 'unsigned int' to 'uint'
>>   * Change some ints to uint, where it makes more sense
>>     (gclocker_stalled_count for example)
>>
>> Webrev:
>> http://cr.openjdk.java.net/~mlarsson/8066771/webrev.00/
>>
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8066771
>>
>> Testing:
>> jprt, local jtreg (test/gc)
>>
>> Thanks,
>> Marcus
>



More information about the hotspot-gc-dev mailing list