RFR: 8066771: Refactor VM GC operations caused by allocation failure
marcus.larsson at oracle.com
Thu Feb 5 15:49:32 UTC 2015
On 04/02/15 22:21, Jon Masamitsu wrote:
> Many of the changes seem not to relate directly to the
> CR. For example the change "unsigned int -> uint" are
> the only changes is some files. Though that would be
> bearable in a code review, it makes more work for
> sustaining when they go hunting for a change that lead
> to a bug. Please consider integrating those under
> a different CR.
I made the cleanup changes a separate CR.
New refactoring webrev:
> Please create a CR to rename the sub-classes of
> VM_CollectForAllocation with synopsis "Regularize
> name of VM_CollectForAllocation and subclasses".
> Assign it to me.
> The changes themselves look good.
> Pending your decision of separating out the unrelated
> changes, consider it reviewed.
Thank you for reviewing!
> On 2/4/2015 7:30 AM, Marcus Larsson wrote:
>> Hello again,
>> Still looking for reviews for this old forgotten change.
>> On 08/12/14 12:39, Marcus Larsson wrote:
>>> I would like reviews for the following patch, cleaning up and
>>> refactoring VM GC operations for failed allocations.
>>> Different GCs have specialized VM_GC_Operations for collecting due
>>> to allocation failure. Part of this code is duplicated. The patch
>>> adds a VM_CollectForAllocation class that removes this duplicated
>>> code and handles the allocation size and result for such operations.
>>> It also serves as a common base where tracing can easily be added
>>> for these operations, regardless of which GC is used.
>>> In addition to the above refactoring, the patch also cleans up
>>> around the VM GC operations. These changes include:
>>> * Indentation and whitespace fixes
>>> * Change 'unsigned int' to 'uint'
>>> * Change some ints to uint, where it makes more sense
>>> (gclocker_stalled_count for example)
>>> jprt, local jtreg (test/gc)
More information about the hotspot-gc-dev