RFR: 8066771: Refactor VM GC operations caused by allocation failure

Bengt Rutisson bengt.rutisson at oracle.com
Fri Feb 6 08:05:36 UTC 2015


Hi Marcus,

Both webrevs look good to me.

Bengt

On 2/5/15 4:49 PM, Marcus Larsson wrote:
> Hi Jon,
>
> On 04/02/15 22:21, Jon Masamitsu wrote:
>> Marcus,
>>
>> Many of the changes seem not to relate directly to the
>> CR.  For example the change "unsigned int -> uint" are
>> the only changes is some files.  Though that would be
>> bearable in a code review, it makes  more work for
>> sustaining when they go hunting for a change that lead
>> to a bug.   Please consider integrating those under
>> a different CR.
>>
>
> I made the cleanup changes a separate CR.
>
> Cleanup issue:
> https://bugs.openjdk.java.net/browse/JDK-8072621
>
> Cleanup webrev:
> http://cr.openjdk.java.net/~mlarsson/8072621/webrev.00/
>
> New refactoring webrev:
> http://cr.openjdk.java.net/~mlarsson/8066771/webrev.01/
>
>> Please create a CR to rename the sub-classes of
>> VM_CollectForAllocation with synopsis "Regularize
>> name of VM_CollectForAllocation and subclasses".
>> Assign it to me.
>
> Done!
>
>>
>> The changes themselves look good.
>>
>> Pending your decision of separating out the unrelated
>> changes, consider it reviewed.
>>
>> Jon
>
> Thank you for reviewing!
> Marcus
>
>>
>> On 2/4/2015 7:30 AM, Marcus Larsson wrote:
>>> Hello again,
>>>
>>> Still looking for reviews for this old forgotten change.
>>>
>>> Thanks,
>>> Marcus
>>>
>>> On 08/12/14 12:39, Marcus Larsson wrote:
>>>> Hi,
>>>>
>>>> I would like reviews for the following patch, cleaning up and 
>>>> refactoring VM GC operations for failed allocations.
>>>>
>>>> Summary:
>>>> Different GCs have specialized VM_GC_Operations for collecting due 
>>>> to allocation failure. Part of this code is duplicated. The patch 
>>>> adds a VM_CollectForAllocation class that removes this duplicated 
>>>> code and handles the allocation size and result for such 
>>>> operations. It also serves as a common base where tracing can 
>>>> easily be added for these operations, regardless of which GC is used.
>>>>
>>>> In addition to the above refactoring, the patch also cleans up 
>>>> around the VM GC operations. These changes include:
>>>>   * Indentation and whitespace fixes
>>>>   * Change 'unsigned int' to 'uint'
>>>>   * Change some ints to uint, where it makes more sense
>>>>     (gclocker_stalled_count for example)
>>>>
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~mlarsson/8066771/webrev.00/
>>>>
>>>> Bug:
>>>> https://bugs.openjdk.java.net/browse/JDK-8066771
>>>>
>>>> Testing:
>>>> jprt, local jtreg (test/gc)
>>>>
>>>> Thanks,
>>>> Marcus
>>>
>>
>



More information about the hotspot-gc-dev mailing list