comments in globals.hpp

Kirk Pepperdine kirk.pepperdine at gmail.com
Fri Feb 6 09:21:50 UTC 2015


Hi,

We have this from g1CollectedHeap.cpp

bool G1CollectedHeap::should_do_concurrent_full_gc(GCCause::Cause cause) {
  switch (cause) {
    case GCCause::_gc_locker:               return GCLockerInvokesConcurrent;
    case GCCause::_java_lang_system_gc:     return ExplicitGCInvokesConcurrent;
    case GCCause::_g1_humongous_allocation: return true;
    default:                                return false;
  }
}

and this from globals.hpp

  product(bool, ExplicitGCInvokesConcurrent, false,                         \
          "A System.gc() request invokes a concurrent collection; "         \
          "(effective only when UseConcMarkSweepGC)”)  

Looks like the comment isn’t in sync with the code?

Kind Regards,
Kirk Pepperdine
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20150206/8e6f2796/attachment-0001.html>


More information about the hotspot-gc-dev mailing list