comments in globals.hpp

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Fri Feb 6 14:30:02 UTC 2015


Hi Kirk,

Thanks for reporting this!
I filed a bug:
https://bugs.openjdk.java.net/browse/JDK-8072688

and have a fix out for review:
http://cr.openjdk.java.net/~jwilhelm/8072688/webrev.00/

Thanks,
/Jesper


Kirk Pepperdine skrev den 6/2/15 10:21:
> Hi,
>
> We have this from g1CollectedHeap.cpp
>
> bool G1CollectedHeap::should_do_concurrent_full_gc(GCCause::Cause cause) {
> switch (cause) {
> case GCCause::_gc_locker: return GCLockerInvokesConcurrent;
> case GCCause::_java_lang_system_gc: return ExplicitGCInvokesConcurrent;
> case GCCause::_g1_humongous_allocation: return true;
> default: return false;
>    }
> }
>
> and this from globals.hpp
>
>    product(bool, ExplicitGCInvokesConcurrent, false,                         \
> "A System.gc() request invokes a concurrent collection; "        \
> "(effective only when UseConcMarkSweepGC)”)
>
> Looks like the comment isn’t in sync with the code?
>
> Kind Regards,
> Kirk Pepperdine


More information about the hotspot-gc-dev mailing list