RFR (S):8067891 Remove vestigal G1SATBCT barrier set kind

Kim Barrett kim.barrett at oracle.com
Fri Feb 6 20:38:24 UTC 2015


On Feb 5, 2015, at 6:51 PM, Joseph Provino <joseph.provino at oracle.com> wrote:
> 
> Please review these changes:
> 
> webrev is here: http://cr.openjdk.java.net/~jprovino/8067891/webrev.00/

Not a review, but rather a "please wait" request.

src/cpu/ppc/vm/macroAssembler_ppc.cpp
2313   G1SATBCardTableModRefBS* bs = (G1SATBCardTableModRefBS*) Universe::heap()->barrier_set();
2314   assert(bs->kind() == BarrierSet::G1SATBCTLogging, "wrong barrier");

Pre-existing bug:

The assertion after the cast is wrong; if the barrier set is not of
the indicated type, the preceding cast has already invoked undefined
behavior.  There are more of these.

I would *really* like to deal with
https://bugs.openjdk.java.net/browse/JDK-8069016 first, before having
BarrierSet::G1SATBCT addressed.  I have a fix that works, but need a
little time to tidy it up and then get it reviewed. I've been
distracted by other things recently, but hoped to get this out for
review in the next couple of days.

Unfortunately, I forgot to make JDK-8069016 a blocker for JDK-8067891.




More information about the hotspot-gc-dev mailing list