RFR (XXS): 8072688: Description of flag ExplicitGCInvokesConcurrent should mantion G1 as well [Was: Re: comments in globals.hpp]

Thomas Schatzl thomas.schatzl at oracle.com
Mon Feb 9 16:06:20 UTC 2015


Hi,

On Mon, 2015-02-09 at 16:17 +0100, Jesper Wilhelmsson wrote:
> Mikael Gerdin skrev den 9/2/15 16:08:
> > On 2015-02-09 16:01, Thomas Schatzl wrote:
> >> Hi Jesper,
> >>
> >> On Fri, 2015-02-06 at 15:30 +0100, Jesper Wilhelmsson wrote:
> >>> Hi Kirk,
> >>>
> >>> Thanks for reporting this!
> >>> I filed a bug:
> >>> https://bugs.openjdk.java.net/browse/JDK-8072688
> >>>
> >>> and have a fix out for review:
> >>> http://cr.openjdk.java.net/~jwilhelm/8072688/webrev.00/
> >>>
> >>
> >>    looks good - not sure if the explicit mention of the two collectors is
> >> necessary. We do not do it for many other flags either.
> >
> > I agree that it would be better to not mention any specific GC:
> > "effective only when a concurrent GC is enabled"
> > is my suggestion.

looks good.

Thanks,
 Thomas




More information about the hotspot-gc-dev mailing list