RFR (XXS): 8072688: Description of flag ExplicitGCInvokesConcurrent should mantion G1 as well [Was: Re: comments in globals.hpp]

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Mon Feb 9 16:47:22 UTC 2015


Thanks Mikael, Thomas, and Kirk for reviewing this fix!
/Jesper

Kirk Pepperdine skrev den 9/2/15 16:32:
> seems reasonable!
>
> Regards,
> Kirk
>
> On Feb 9, 2015, at 4:30 PM, Mikael Gerdin <mikael.gerdin at oracle.com> wrote:
>
>>
>>
>> On 2015-02-09 16:17, Jesper Wilhelmsson wrote:
>>> Mikael Gerdin skrev den 9/2/15 16:08:
>>>> On 2015-02-09 16:01, Thomas Schatzl wrote:
>>>>> Hi Jesper,
>>>>>
>>>>> On Fri, 2015-02-06 at 15:30 +0100, Jesper Wilhelmsson wrote:
>>>>>> Hi Kirk,
>>>>>>
>>>>>> Thanks for reporting this!
>>>>>> I filed a bug:
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8072688
>>>>>>
>>>>>> and have a fix out for review:
>>>>>> http://cr.openjdk.java.net/~jwilhelm/8072688/webrev.00/
>>>>>>
>>>>>
>>>>>    looks good - not sure if the explicit mention of the two
>>>>> collectors is
>>>>> necessary. We do not do it for many other flags either.
>>>>
>>>> I agree that it would be better to not mention any specific GC:
>>>> "effective only when a concurrent GC is enabled"
>>>> is my suggestion.
>>>>
>>>
>>> Since I already changed it to "(effective only when using concurrent
>>> collectors)" and published the new webrev, that is my suggestion :)
>>>
>>> http://cr.openjdk.java.net/~jwilhelm/8072688/webrev.01/
>>
>> That's fine with me.
>>
>> /Mikael
>>
>>>
>>> /Jesper
>>>
>>>> /Mikael
>>>>
>>>>>
>>>>> Maybe if you waited a little more if somebody else feels strongly about
>>>>> this.
>>>>>
>>>>> You do not need to hide the review request too :)
>>>>>
>>>>> Thanks,
>>>>>    Thomas
>>>>>
>>>>>
>


More information about the hotspot-gc-dev mailing list