RFR(S): 8071822: [TEST_BUG] Adapt collectorPolicy internal tests to support 64K pages

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Wed Feb 11 08:45:41 UTC 2015


Hi,

maybe my explanations to this change are too short to easily understand it.

This concerns jtreg test sanity/ExecuteInternalVMTests.java.

The error is
...
Running test: TestNewSize_test()
# To suppress the following error report, specify this argument
# after -XX: or in .hotspotrc: SuppressErrorAt=/collectorPolicy.cpp:1015
#
# A fatal error has been detected by the Java Runtime Environment:
#
# Internal Error (/sapmnt/home1/d045726/oJ/aarch-hs-comp/src/share/vm/memory/collectorPolicy.cpp:1015), pid=30500, tid=4398080324160
# assert(msp.initial_young_size() == expected) failed: 44695552 != 34930688

I also added some explanations in the bug.

Does this help?

Thanks and best regards,
  Goetz.

From: Lindenmaier, Goetz
Sent: Dienstag, 10. Februar 2015 16:43
To: 'hotspot-dev Source Developers'; hotspot-gc-dev at openjdk.java.net
Subject: RE: RFR(S): 8071822: [TEST_BUG] Adapt collectorPolicy internal tests to support 64K pages

Hi,

could someone please have a look at this change?
It's really not that big.

GC-folks maybe?

Thanks,
  Goetz.

From: Lindenmaier, Goetz
Sent: Freitag, 30. Januar 2015 10:36
To: hotspot-dev Source Developers
Subject: RFR(S): 8071822: [TEST_BUG] Adapt collectorPolicy internal tests to support 64K pages

Hi,

this fixes a final problem with 64-bit page size in the jtreg tests.
It addresses the internal VM tests of the collector policies.

Those tests set a row of fixed flag values, and one special value to test.
Then they call the heap ergonomics and check the expected result of the
special value.

With 64K page size, the heap ergonomics adapt more values, breaking the tests.
Wrt. the adapted flag values the tests are correct though.

This change makes the expected values depend on the adapted flags, and the
tests pass. They only depend on adapted flags that are not subject of the
corresponding test.

Please review this test.  I please need a sponsor.

http://cr.openjdk.java.net/~goetz/webrevs/8071822-jtregColPol/webrev.01/<http://cr.openjdk.java.net/~goetz/webrevs/8071822-jtregColPol/webrev.01/src/share/vm/memory/collectorPolicy.cpp.udiff.html>
https://bugs.openjdk.java.net/browse/JDK-8071822


Best regards,
  Goetz.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20150211/f2c5c915/attachment-0001.html>


More information about the hotspot-gc-dev mailing list