RFR: 8072910: Move the g1EvacFailure.hpp implementation to g1EvacFailure.cpp

Thomas Schatzl thomas.schatzl at oracle.com
Wed Feb 11 10:49:49 UTC 2015


Hi Stefan,

On Wed, 2015-02-11 at 10:40 +0100, Stefan Karlsson wrote:
> Hi all,
> 
> Please, review this patch to move the implementation of 
> g1EvacFailure.hpp into a new cpp file. This helps reducing our include 
> dependencies in the header files.
> 
> http://cr.openjdk.java.net/~stefank/8072910/webrev.00/
> https://bugs.openjdk.java.net/browse/JDK-8072910

  is it possible to fix the comment about "Closures and tasks associated
with any self-forwarding pointers..." at the top of the hpp file?

There is only one task and no closures now.

Not sure if that same comment is required in the cpp file. Maybe remove
it.

Otherwise looks good.

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list