RFR: JDK-8061802 - REDO - Remove the generations array

Kim Barrett kim.barrett at oracle.com
Wed Feb 11 18:21:42 UTC 2015


On Feb 11, 2015, at 5:01 AM, Jesper Wilhelmsson <jesper.wilhelmsson at oracle.com> wrote:
> 
> Kim Barrett skrev den 10/2/15 23:56:
>> On Feb 10, 2015, at 3:38 PM, Jesper Wilhelmsson <jesper.wilhelmsson at oracle.com> wrote:
>>> 
>>> Hi Kim,
>>> 
>>> Thanks for taking another close look at this change!
>>> 
>>> Some of these issues are the result of this being a part of a bigger change, but I have addressed your concerns to make sure this intermediate version is of decent quality even without the following cleanups. (Even though I hope we will get the rest in asap. Those will be a lot easier to review).
>>> 
>>> For example anything related to levels and _n_gens will be removed in later patches when the entire level concept is removed.
>> 
>> That’s what I thought, but I would prefer having this changeset be able to stand on its own merits.  I think the further changes will be easier to understand with the additional (usually temporary) asserts and such, especially for anyone who didn’t review this changeset.
>> 
>>> A new webrev is available here:
>>> http://cr.openjdk.java.net/~jwilhelm/8061802/webrev.02/
>> 
>> This webrev seems to be broken - genCollectedHeap.cpp frame display is messed up.  Old version is showing as empty, although new version still highlights differences.  I didn’t look at it carefully though, since I’m not sure I’d be looking at anything like the intended code.
> 
> Yes. Apparently awk (on Mac?) has a hard coded limitation of 50 patterns, so webrev fails to process large files... I have installed gawk now and built a new webrev to replace the old one. (same link)

Bleh.  That must have been fun to track down.

Changes look good.




More information about the hotspot-gc-dev mailing list