RFR(xs): 8073115: assert(_covered_region.contains(p)) needs better error messages

Stefan Karlsson stefan.karlsson at oracle.com
Fri Feb 13 09:07:00 UTC 2015


Hi Sangheon,

On 2015-02-13 07:54, Sangheon Kim wrote:
> Hi All,
>
> Please review this small enhancement for better error messages when assert fails.
> This change would be helpful forJDK-8071930  <https://bugs.openjdk.java.net/browse/JDK-8071930>  which is hard to reproduce.
>
> I will need a sponsor for this change.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8073115
>
> Webrev:
> http://cr.openjdk.java.net/~sangheki/8073115/webrev.00/

http://cr.openjdk.java.net/~sangheki/8073115/webrev.00/src/share/vm/gc_implementation/parallelScavenge/objectStartArray.hpp.udiff.html

You are duplicating the same assert three times. Could you create a new 
define, say #define assert_covered_region_contains(addr) ..., and remove 
the duplication? This will also have the benefit of lowering the line 
noise in the functions you change.

Thanks,
StefanK

>
> Testing:
> JPRT
>
> Thanks,
> Sangheon

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20150213/7552f5e4/attachment-0001.html>


More information about the hotspot-gc-dev mailing list