RFR(xs): 8073115: assert(_covered_region.contains(p)) needs better error messages

Sangheon Kim sangheon.kim at oracle.com
Fri Feb 13 17:40:47 UTC 2015


Hi Jesper,

Thanks for reviewing this and sponsoring this.

Sangheon


On 02/12/2015 11:38 PM, Jesper Wilhelmsson wrote:
> Hi Sangheon,
>
> Looks good!
> Thanks for enhancing the asserts, this is something the Hotspot code 
> is in great need of. I'll be happy to sponsor this change.
> /Jesper
>
>
> Sangheon Kim skrev den 13/2/15 07:54:
>> Hi All,
>>
>> Please review this small enhancement for better error messages when 
>> assert fails.
>> This change would be helpful forJDK-8071930 
>> <https://bugs.openjdk.java.net/browse/JDK-8071930>  which is hard to 
>> reproduce.
>>
>> I will need a sponsor for this change.
>>
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8073115
>>
>> Webrev:
>> http://cr.openjdk.java.net/~sangheki/8073115/webrev.00/
>>
>> Testing:
>> JPRT
>>
>> Thanks,
>> Sangheon
>>



More information about the hotspot-gc-dev mailing list